Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support extending export options #1210

Merged
merged 1 commit into from
Dec 24, 2022

Conversation

dertieran
Copy link
Contributor

Motivation and Context

Support extending the exportOptions through the buildOpts.

Resolves #1209

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

Copy link
Member

@erisu erisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@erisu erisu changed the title Support extending export options feat: support extending export options Mar 15, 2022
@erisu
Copy link
Member

erisu commented Mar 15, 2022

Code wise everything looks good.

Can you provide me your example build command on how you tested it. How you set a single or multiple export options.

This information needs to be added later to the Cordova docs so others understand how to use it.

@dertieran
Copy link
Contributor Author

Not quite sure if this is what you mean, but I'm not using cordova through the cli.
So I didn't provide a way to set the exportOptions through the cli, but I guess it could be added as an option to the build.json.

I tested it through my build script that looks something like this

const build = async function ({ release, platforms }) {
    const exportOptions = { uploadSymbols: !release };
    const options = { release, device: release, exportOptions };
    await cordova.build({ verbose: !release, platforms, options });
};

build({ release: true, platforms: ['ios'] });

This will then not include the .symbols in the produced .ipa file.
This command should not print anything in that case (by default it does).

unzip -l platforms/ios/build/device/<app>.ipa | grep Symbols

Also as mentioned in the issue, right now the code does not allow to overwrite the defaults.
Not sure if that would be a good idea or if it would break the whole build. 😅

I hope this helps, let me know if I can help with anything else.

@dpogue dpogue merged commit dba1704 into apache:master Dec 24, 2022
@dpogue dpogue added this to the 7.0.0 milestone Dec 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support extending export options
3 participants