Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support multiple provisioning profiles #1251

Merged
merged 1 commit into from
Sep 5, 2022
Merged

Conversation

ollm
Copy link
Contributor

@ollm ollm commented Aug 31, 2022

Platforms affected

iOS

Motivation and Context

Description

Rebase against the main branch this pull request #956

Closes #956

Testing

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

Copy link
Member

@erisu erisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is identical to my previous review in #956, with the exception for the file that no longer exists in the main branch.

I had already tested the following commands to confirm that the standard process continues to build successfully. (with & without build.json configurations) under the previous PR.

  • cordova build ios
  • cordova build ios --debug
  • cordova build ios --release
  • cordova run ios (simulator) (ad-hoc)

I also uploaded the built release (ad-hoc) ipa to a physical device running iOS 15.6.1.

As for testing multiple provisioning profiles, I do not have a project to confirm the feature/settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants