Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(ios) fix: workaround for DisallowOverscroll on iOS 16 #1258

Merged
merged 1 commit into from
Oct 12, 2022

Conversation

vbraun
Copy link
Contributor

@vbraun vbraun commented Sep 14, 2022

Platforms affected

iOS 16

Motivation and Context

iOS 16 breaks DisallowOverscroll setting, this PR adds workaround discussed in #1244

Description

Disabling both webView.scrollView.bounce and webView.scrollView.alwaysBounceVertical

Testing

Manually tested on iOS 15 and iOS 16

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

Closes #1244

Copy link
Member

@dpogue dpogue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like for consistency, we do also want to set scrollView.alwaysBounceHorizontal = NO; otherwise there's a risk of unwanted side-to-side rubberbanding.

@vbraun vbraun force-pushed the ios-16-workaround-DisallowOverscroll branch from dccf238 to f192df1 Compare September 14, 2022 17:19
@vbraun
Copy link
Contributor Author

vbraun commented Sep 14, 2022

Good point, added.

@codecov-commenter
Copy link

codecov-commenter commented Oct 12, 2022

Codecov Report

Merging #1258 (f192df1) into master (af7512a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1258   +/-   ##
=======================================
  Coverage   78.26%   78.26%           
=======================================
  Files          15       15           
  Lines        1767     1767           
=======================================
  Hits         1383     1383           
  Misses        384      384           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dpogue dpogue added this to the 6.2.1 milestone Oct 12, 2022
@dpogue dpogue merged commit f804a42 into apache:master Oct 12, 2022
@u01jmg3
Copy link

u01jmg3 commented Nov 13, 2022

@dpogue when do you intend to release 6.2.1?

u01jmg3 pushed a commit to uofa/cordova-ios that referenced this pull request Dec 3, 2022
tiagoappereira pushed a commit to OutSystems/cordova-ios that referenced this pull request Dec 13, 2022
@u01jmg3
Copy link

u01jmg3 commented Dec 14, 2022

This issue looks to have been fixed in iPadOS 16.2 released yesterday (Dec 13th).

@NiklasMerz NiklasMerz removed this from the 6.2.1 milestone Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DisallowOverscroll does not work on iOS 16
5 participants