Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: remove Node 10-12 & added Node 16-18 #1271

Merged
merged 1 commit into from
Nov 24, 2022

Conversation

TylerBreau
Copy link
Contributor

@TylerBreau TylerBreau commented Nov 22, 2022

Platforms affected

iOS

Motivation and Context

Node 10 and 12 is already EOL.

Description

Updated ci.yml.
Removed node 10.x and 12.x.
Added node 16.x and 18.x.
Supported versions are 14.x, 16.x, and 18.x.

Testing

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@breautek breautek added this to the 7.0.0 milestone Nov 22, 2022
@breautek breautek changed the title Updated ci.yml node versions to 16.x and 18.x Chore(ci): Removed Node 10-14. Added Node 16-18 Nov 22, 2022
@breautek breautek changed the title Chore(ci): Removed Node 10-14. Added Node 16-18 chore(ci): Removed Node 10-14. Added Node 16-18 Nov 22, 2022
@breautek breautek requested a review from erisu November 22, 2022 18:19
@erisu erisu changed the title chore(ci): Removed Node 10-14. Added Node 16-18 ci(workflow): remove Node 10-14 & added Node 16-18 Nov 22, 2022
@erisu erisu changed the title ci(workflow): remove Node 10-14 & added Node 16-18 ci: remove Node 10-14 & added Node 16-18 Nov 22, 2022
Supported Node versions include 14-18.
@TylerBreau TylerBreau changed the title ci: remove Node 10-14 & added Node 16-18 ci: remove Node 10-12 & added Node 16-18 Nov 23, 2022
@codecov-commenter
Copy link

codecov-commenter commented Nov 24, 2022

Codecov Report

Merging #1271 (268fb44) into master (f804a42) will increase coverage by 78.26%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #1271       +/-   ##
===========================================
+ Coverage        0   78.26%   +78.26%     
===========================================
  Files           0       15       +15     
  Lines           0     1767     +1767     
===========================================
+ Hits            0     1383     +1383     
- Misses          0      384      +384     
Impacted Files Coverage Δ
lib/build.js 63.69% <0.00%> (ø)
lib/prepare.js 85.00% <0.00%> (ø)
lib/listEmulatorImages.js 100.00% <0.00%> (ø)
lib/versions.js 89.36% <0.00%> (ø)
lib/Api.js 71.76% <0.00%> (ø)
lib/plugman/pluginHandlers.js 90.05% <0.00%> (ø)
lib/PodsJson.js 95.04% <0.00%> (ø)
lib/create.js 95.83% <0.00%> (ø)
lib/check_reqs.js 47.05% <0.00%> (ø)
lib/BridgingHeader.js 95.45% <0.00%> (ø)
... and 5 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@breautek breautek merged commit 6e93ee9 into apache:master Nov 24, 2022
@breautek breautek deleted the update-node branch November 24, 2022 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants