Set webView.inspectable to true for debug builds on iOS >= 16.4

[BBosman]

Platforms affected

iOS

Motivation and Context

With the introduction of iOS 16.4 WKWebView instances will no longer be inspectable by default.

Details: Enabling the Inspection of Web Content in Apps

Description

This PR honors that change for Release builds, but explicitly sets the inspectability to YES for Debug builds by default.
It also introduce an override option, so consumers can influence this decision in their own build.

Testing

Tested the code in one of our own apps.

Checklist

• I've run the tests to see all new and existing tests pass
• I added automated test coverage as appropriate for this change
• Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
• If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
• I've updated the documentation if necessary

[dpogue]

The master branch is already targeting the next major version, so I think we want to default this to NO in release builds (and YES in debug builds).

Thanks for adding the preference too! We'll want to add that to the cordova-docs repo (and maybe file an issue on cordova-android to obey the preference for inspecting there too)

[BBosman]

@dpogue I've updated the code and PR description based on your feedback.

I had to remove the default value for the setting from defaults.xml, as that would always override the build based default setting in the code.

[dpogue]

LGTM

[BBosman]

I can't explain the CI failure, but it looks unrelated to my changes?

[dpogue]

I can't explain the CI failure, but it looks unrelated to my changes?

yeah, test failures are due to some URL parsing changes in Node 18, unrelated to these changes 😞

[breautek]

I can't explain the CI failure, but it looks unrelated to my changes?

That issue is caused by #1290 for reference.

Concerns about allowing inspectable webview in the CordovaWebview where it has access to native device APIs

[breautek]

Disclaimer: Non-lawyer analysis.

I revoked my previous approval out of concerns that allowing webview to be inspectable may be in a clear violation of Section 4.7.1 of the App Guidelines.

However I believe Section 4.7.1 only applies to code that isn't bundled with the App binary. And I didn't find anything else (In the Apple Developer Agreement and XCode terms of use) that says device APIs cannot be exposed to users outside the developer platform.

Therefore, at the core, I think Cordova is in the clear, for both the core platform & use in the in app browser plugin (should the plugin also obey this kind of flag, which I know there is a PR to introduce that functionality).

If the developer does import code from remote sources then they may be breaching the agreement with Apple, however that isn't the concern of Apache Cordova, it will be up to the end-users to ensure they comply with Apple's terms.

So I'm returning my approval.

[NiklasMerz]

Tested with an iPad and code looks good to me. I will also merge this into a path release

[daviesdoclc]

This is not working for me on iOS 16.4.1, MacOS 13.3.1, Safari 16.4.

I'm running as follows:
cordova run ios --device --debug

I also tried setting InspectableWebview to true in config.xml.

[breautek]

This is not working for me on iOS 16.4.1, MacOS 13.3.1, Safari 16.4.

I'm running as follows: cordova run ios --device --debug

I also tried setting InspectableWebview to true in config.xml.

Let's create a new issue, using the issue template so that we can try to drill down and isolate the cause.