Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dep!: bump all possible dependencies w/ node engine requirement update >=16.13.0 #1305

Merged
merged 14 commits into from
Apr 14, 2023

Conversation

erisu
Copy link
Member

@erisu erisu commented Apr 13, 2023

Platforms affected

n/a

Motivation and Context

Use latest dependencies and remove any audit warnings in package-lock.json

Description

Bumped:

Other:

Testing

npm t

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@erisu erisu added the dependencies Pull requests that update a dependency file label Apr 13, 2023
@erisu erisu added this to the 7.0.0 milestone Apr 13, 2023
@erisu erisu requested a review from NiklasMerz April 13, 2023 10:17
@codecov-commenter
Copy link

codecov-commenter commented Apr 13, 2023

Codecov Report

Merging #1305 (55e37ec) into master (ad60924) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1305   +/-   ##
=======================================
  Coverage   78.25%   78.25%           
=======================================
  Files          15       15           
  Lines        1761     1761           
=======================================
  Hits         1378     1378           
  Misses        383      383           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dpogue
Copy link
Member

dpogue commented Apr 13, 2023

We're still testing Node 14 in CI (and somehow it appears to be passing?)... presumably we should drop that if we're introducing a node 16.13.0 minimum?

@erisu
Copy link
Member Author

erisu commented Apr 13, 2023

@dpogue yes, you are correct. I have dropped Node 14.x from the CI. Because of the bumping of the packages that increased the node engine requirement, it should also include the CI changes.

@erisu erisu changed the title dep!: bump all possible dependencies dep!: bump all possible dependencies w/ node engine requirement update >=16.13.0 Apr 13, 2023
@breautek

This comment was marked as resolved.

@erisu erisu merged commit 7352502 into apache:master Apr 14, 2023
8 checks passed
@erisu erisu deleted the feat/bump-dependencies branch April 14, 2023 09:49
@dpogue dpogue linked an issue May 7, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update jasmine and ios-sim for major release
4 participants