fix(create): Ensure unix paths in Xcode project file #1312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cordova-iOS requires macOS for building and deploying, but it seems to be a fairly common problem that people generate the iOS project files on Windows (which isn't technically supported, but _appears_ to work) and then Xcode can't open it on macOS because of a bad path separator. The path separator problem is fixable, so let's at least generate a valid Xcode project. This does *not* claim to add support for using Cordova-iOS on Windows. Closes apache#971. Closes apache#1016. Closes apache#1084.
Codecov Report
@@ Coverage Diff @@
## master #1312 +/- ##
==========================================
- Coverage 78.48% 78.45% -0.04%
==========================================
Files 15 15
Lines 1780 1782 +2
==========================================
+ Hits 1397 1398 +1
- Misses 383 384 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
breautek
approved these changes
May 17, 2023
erisu
approved these changes
May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
iOS
Motivation and Context
Cordova-iOS requires macOS for building and deploying, but it seems to be a fairly common problem that people generate the iOS project files on Windows (which isn't technically supported, but appears to work) and then Xcode can't open it on macOS because of a bad path separator.
Description
The path separator problem is fixable, so let's at least generate a valid Xcode project.
This does not claim to add support for using Cordova-iOS on Windows.
Closes #971.
Closes #1016.
Closes #1084.
Testing
Split out tests for the created project into a test case that runs on all platforms, while keeping the tests that create and build only running on macOS.
Checklist