feat: add listTarget api & revert original bin file location #1320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1320 +/- ##
==========================================
+ Coverage 78.51% 78.64% +0.13%
==========================================
Files 15 15
Lines 1778 1789 +11
==========================================
+ Hits 1396 1407 +11
Misses 382 382
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
dpogue
approved these changes
Apr 25, 2023
dpogue
approved these changes
May 2, 2023
| module.exports.runListDevices = async function (options) { | ||
| const { options: cliArgs } = options; | ||
| module.exports.runListDevices = async function (options = {}) { | ||
| const { options: cliArgs = {} } = options; |
There was a problem hiding this comment.
const cliArgs = options.options ?? {}; seems way easier to read IMO, but I know that's not the "cool" way of doing things anymore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
n/a
Motivation and Context
Support calling for listTarget on the PlatformAPI.
Will be used by Cordova CLI/Lib 12
Reverted the location of the binraries to the original location. Needed for older CLI versions.
Description
Added
listTargetson platform api and added supporting methods in therun.jsfileTesting
npm tChecklist
(platform)if this change only applies to one platform (e.g.(android))