Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make the WebView the first responder when it loads #1337

Merged
merged 1 commit into from
Jun 6, 2023

Conversation

dpogue
Copy link
Member

@dpogue dpogue commented Jun 6, 2023

Fixes #1132.
Maybe fixes #455.

Platforms affected

iOS

Motivation and Context

Presently, the splashscreen becomes the focused view when the app loads, and it never moves focus back to the webview. This means that the webview does not receive events (such as keypresses) until it is explicitly focused by the user (by tapping in it). We want the webview to become the focused element when the splashscreen is hidden.

Description

Upon hiding the splashscreen, set the webview as the first responder for event handling.

Testing

Tested this in iOS simulator and on macOS (with Catalyst)

Checklist

  • I've run the tests to see all new and existing tests pass

@dpogue dpogue added this to the 7.0.0 milestone Jun 6, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jun 6, 2023

Codecov Report

Merging #1337 (f631c8b) into master (58df099) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1337   +/-   ##
=======================================
  Coverage   78.62%   78.62%           
=======================================
  Files          15       15           
  Lines        1801     1801           
=======================================
  Hits         1416     1416           
  Misses        385      385           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@erisu erisu changed the title Make the WebView the first responder when it loads fix: make the WebView the first responder when it loads Jun 6, 2023
@dpogue dpogue merged commit 62a4b74 into apache:master Jun 6, 2023
9 checks passed
@dpogue dpogue deleted the focus-fix branch June 6, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants