Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove unused BackupWebStorage preference #1339

Merged
merged 1 commit into from
Jun 7, 2023

Conversation

dpogue
Copy link
Member

@dpogue dpogue commented Jun 7, 2023

Fixes #1332.

Platforms affected

iOS

Motivation and Context

This preference is unused (since at least the move from UIWebView to WKWebView)

Description

Remove some special handling that was being done in CDVViewController for an unused BackupWebStorage preference.

Testing

Unit tests pass.

Checklist

  • I've run the tests to see all new and existing tests pass
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)

@dpogue dpogue added this to the 7.0.0 milestone Jun 7, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jun 7, 2023

Codecov Report

Merging #1339 (b5abeb6) into master (98910de) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1339   +/-   ##
=======================================
  Coverage   78.62%   78.62%           
=======================================
  Files          15       15           
  Lines        1801     1801           
=======================================
  Hits         1416     1416           
  Misses        385      385           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@erisu erisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dpogue dpogue merged commit 700c32b into apache:master Jun 7, 2023
9 checks passed
@dpogue dpogue deleted the backup-web-storage branch June 7, 2023 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove unused BackupWebStorage preference handling
3 participants