Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: Remove podspec support from framework tag #1340

Merged
merged 1 commit into from
Jun 7, 2023

Conversation

dpogue
Copy link
Member

@dpogue dpogue commented Jun 7, 2023

Closes #812.

Platforms affected

iOS

Motivation and Context

<framework type="podspec"> has been deprecated in favour of the <podspec> tag that allows much more control over pod dependencies.

Description

Remove support for <framework type="podspec"> and print an error if such framework tags are found.

Testing

Removed unit tests around special case handling for podspec framework tags.

Checklist

  • I've run the tests to see all new and existing tests pass
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)

This has been deprecated in favour of the <podspec> tag that allows much
more control over pod dependencies.

Closes apache#812.
@dpogue dpogue added this to the 7.0.0 milestone Jun 7, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jun 7, 2023

Codecov Report

Merging #1340 (7445c88) into master (98910de) will decrease coverage by 0.04%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master    #1340      +/-   ##
==========================================
- Coverage   78.62%   78.58%   -0.04%     
==========================================
  Files          15       15              
  Lines        1801     1770      -31     
==========================================
- Hits         1416     1391      -25     
+ Misses        385      379       -6     
Impacted Files Coverage Δ
lib/plugman/pluginHandlers.js 89.69% <0.00%> (-0.47%) ⬇️
lib/Api.js 71.11% <100.00%> (-0.88%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dpogue dpogue marked this pull request as ready for review June 7, 2023 05:31
Copy link
Member

@erisu erisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is a major release, I think it is safe to remove the deprecated framework tag's attribute podspec.

The new method <podspec> was introduced in Cordova-iOS@5.0.0 (Feb 07, 2019).

Plugin developers had 4 years to migrate to the new tag.

@dpogue dpogue merged commit 76e33d9 into apache:master Jun 7, 2023
9 checks passed
@dpogue dpogue deleted the podspec-fixes branch June 7, 2023 06:00
deanylev added a commit to viviedu/cordova-ios that referenced this pull request Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove type="podspec" from framework tag
3 participants