Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Try updating Podfile deployment target on prepare #1341

Merged
merged 1 commit into from
Jun 29, 2023

Conversation

dpogue
Copy link
Member

@dpogue dpogue commented Jun 7, 2023

Platforms affected

iOS

Motivation and Context

Description

Testing

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@dpogue dpogue linked an issue Jun 7, 2023 that may be closed by this pull request
3 tasks
@codecov-commenter
Copy link

codecov-commenter commented Jun 7, 2023

Codecov Report

Merging #1341 (ae52f6e) into master (6db1b6e) will decrease coverage by 0.37%.
The diff coverage is 14.89%.

@@            Coverage Diff             @@
##           master    #1341      +/-   ##
==========================================
- Coverage   78.62%   78.25%   -0.37%     
==========================================
  Files          15       15              
  Lines        1773     1789      +16     
==========================================
+ Hits         1394     1400       +6     
- Misses        379      389      +10     
Impacted Files Coverage Δ
lib/Api.js 81.00% <0.00%> (+9.50%) ⬆️
lib/PodsJson.js 75.00% <9.67%> (-20.05%) ⬇️
lib/prepare.js 83.37% <30.76%> (-1.66%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dpogue dpogue added this to the 7.0.0 milestone Jun 8, 2023
@dpogue dpogue linked an issue Jun 8, 2023 that may be closed by this pull request
3 tasks
@dpogue dpogue marked this pull request as ready for review June 12, 2023 13:42
Copy link
Member

@erisu erisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I tested setting the deployment target and confirm that the pods targets were updated.

@erisu erisu merged commit ad57677 into apache:master Jun 29, 2023
9 checks passed
@dpogue dpogue deleted the pod-deployment-target branch March 8, 2024 18:11
deanylev added a commit to viviedu/cordova-ios that referenced this pull request Apr 24, 2024
deanylev added a commit to viviedu/cordova-ios that referenced this pull request Apr 24, 2024
deanylev added a commit to viviedu/cordova-ios that referenced this pull request Apr 24, 2024
deanylev added a commit to viviedu/cordova-ios that referenced this pull request Apr 24, 2024
deanylev added a commit to viviedu/cordova-ios that referenced this pull request Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants