Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ensure Xcode project file references use path #1358

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

dpogue
Copy link
Member

@dpogue dpogue commented Jul 18, 2023

Platforms affected

iOS

Motivation and Context

Closes GH-1357.

Description

After moving some files around in cordova-ios 7.0.0, Xcode opted to use a name attribute in the Xcode project file rather than a path attribute. This is valid from Xcode's perspective, but fails expectations of the node-xcode library that we use for manipulating the project file.

Ensure that every file in the project has an explicit path specified.

Testing

...

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)

@ashish-mahour
Copy link

ashish-mahour commented Aug 3, 2023

Hi @dpogue,
When we can expect this fix to be released?

@dpogue
Copy link
Member Author

dpogue commented Aug 3, 2023

When we can expect this fix to be released?

When someone has time to put together a release and go through the voting process. Cordova is maintained by volunteers in their free time.

@seamlink-aalves
Copy link

Hi,

I could not update to version 7 of cordova-ios due to this error. I've tested this PR with our Apps and it fixed this issue.

@dpogue dpogue merged commit 83cd825 into apache:master Aug 29, 2023
9 checks passed
@dpogue dpogue deleted the xcode-paths branch August 29, 2023 22:11
@dpogue dpogue added this to the 7.0.1 milestone Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cordova-ios@7 breaks cordova-node-xcode addBuildPhase
5 participants