Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add missing cordova versions to CDVAvailability.h #1360

Merged
merged 1 commit into from
Jul 20, 2023

Conversation

jcesarmobile
Copy link
Member

@jcesarmobile jcesarmobile commented Jul 20, 2023

This is supposedly done by coho during the release process, but looks like last two releases failed to do it, so the versions are missing.

EDIT:
CDVAvailability.h file was moved, so the code in coho was not working, I've updated the path on coho
apache/cordova-coho#323

@codecov-commenter
Copy link

codecov-commenter commented Jul 20, 2023

Codecov Report

Merging #1360 (a810e60) into master (19e931e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1360   +/-   ##
=======================================
  Coverage   78.25%   78.25%           
=======================================
  Files          15       15           
  Lines        1789     1789           
=======================================
  Hits         1400     1400           
  Misses        389      389           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dpogue dpogue merged commit 6e71f54 into master Jul 20, 2023
12 of 18 checks passed
@dpogue dpogue deleted the jcesarmobile-patch-1 branch July 20, 2023 13:55
usernuno pushed a commit to OutSystems/cordova-ios that referenced this pull request Jul 26, 2023
@dpogue dpogue added this to the 7.0.1 milestone Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants