feat: SplashScreen Background Color preference support #1411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpogue
force-pushed
the
splashscreen-background-colour
branch
from
53e37e8
to
e10fd3d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1411 +/- ##
==========================================
- Coverage 78.50% 78.37% -0.13%
==========================================
Files 16 16
Lines 1814 1827 +13
==========================================
+ Hits 1424 1432 +8
- Misses 390 395 +5 ☔ View full report in Codecov by Sentry. |
dpogue
force-pushed
the
splashscreen-background-colour
branch
from
e10fd3d
to
a5e9b0b
Compare
dpogue
force-pushed
the
splashscreen-background-colour
branch
from
a5e9b0b
to
a9da7e2
Compare
dpogue
added a commit
to dpogue/cordova-docs
that referenced
this pull request
Mar 28, 2024
Include some preferences that were missing for auto-hiding and controlling splash screen delays, and also add the iOS `SplashScreenBackgroundColor` preference (from apache/cordova-ios#1411)
1 task
|
Docs PR: apache/cordova-docs#1348 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
iOS
Motivation and Context
Closes #1254.
Description
Support a
SplashScreenBackgroundColorpreference that sets the background colour of the splash screen via xcassets.If no
SplashScreenBackgroundColoris provided, it will fall back to theBackgroundColor(i.e., the current behaviour).If neither are specified, it will fallback to the system background colour (also current behaviour).
Testing
BackgroundColorandSplashScreenBackgroundColorpreferences. Ensured both variables had correct values in Xcode and confirmed splash screen used the correct colour on device.BackgroundColorpreference. Ensured both variables had correct values in Xcode and confirmed splash screen used the correct colour on device.Checklist