Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Modernize some dependencies #1413

Merged
merged 1 commit into from
Mar 29, 2024
Merged

Conversation

dpogue
Copy link
Member

@dpogue dpogue commented Mar 24, 2024

Platforms affected

iOS

Motivation and Context

This allows us to drop the fs-extra and unorm library by replacing their use with built-in NodeJS standard library calls.

Description

  • Replace unorm module with String.prototype.normalize
  • Replace fs-extra usage with equivalent NodeJS fs calls
  • Upgrade which to latest version
  • Use path.join in a bunch of spots where we're constructing paths
  • Remove the (unused) nopt dependency

Testing

  • Existing unit tests pass
  • Created and built iOS test project

Checklist

  • I've run the tests to see all new and existing tests pass

@codecov-commenter
Copy link

codecov-commenter commented Mar 24, 2024

Codecov Report

Attention: Patch coverage is 86.56716% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 78.47%. Comparing base (1974dbb) to head (7ddec78).

Files Patch % Lines
lib/prepare.js 75.00% 3 Missing ⚠️
lib/run.js 50.00% 3 Missing ⚠️
lib/Api.js 75.00% 1 Missing ⚠️
lib/build.js 85.71% 1 Missing ⚠️
lib/plugman/pluginHandlers.js 92.85% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1413      +/-   ##
==========================================
- Coverage   78.50%   78.47%   -0.03%     
==========================================
  Files          16       16              
  Lines        1814     1812       -2     
==========================================
- Hits         1424     1422       -2     
  Misses        390      390              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@erisu erisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dpogue dpogue marked this pull request as ready for review March 28, 2024 22:04
@dpogue dpogue added this to the 7.1.0 milestone Mar 28, 2024
@dpogue dpogue merged commit f7e2953 into apache:master Mar 29, 2024
10 checks passed
@dpogue dpogue deleted the deps-202403 branch March 29, 2024 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants