Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dep!: drop fs-extra for internal node:fs & bump node engine >=16.20.2 #266

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

erisu
Copy link
Member

@erisu erisu commented Apr 3, 2024

Platforms affected

n/a

Motivation and Context

Replace fs-extra for node internal fs package.

Description

  • Remove fs-extra package
  • Use node:fs and node:fs/promises
  • Bump node engine requirement to >=16.20.2

Testing

  • npm t

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.62%. Comparing base (c7d3dc0) to head (f1e5c75).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #266   +/-   ##
=======================================
  Coverage   83.62%   83.62%           
=======================================
  Files          14       14           
  Lines         519      519           
=======================================
  Hits          434      434           
  Misses         85       85           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@erisu erisu merged commit d97d8f9 into apache:master Apr 8, 2024
9 checks passed
@erisu erisu deleted the dep/drop-fs-extra-for-internal branch April 8, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants