Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: try update codecov@v4 w/ token #272

Closed
wants to merge 1 commit into from

Conversation

erisu
Copy link
Member

@erisu erisu commented Apr 10, 2024

Platforms affected

n/a

Motivation and Context

v3 no longer works without token and v4 also requires token.

Tested alternative code coverage tools, such as coveralls, and they also require a token. #271

Will attempt to update codecov instead.

Description

update codecov and set token property

Testing

n/a

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@codecov-commenter
Copy link

codecov-commenter commented Apr 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.62%. Comparing base (c7d3dc0) to head (500bb0a).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #272   +/-   ##
=======================================
  Coverage   83.62%   83.62%           
=======================================
  Files          14       14           
  Lines         519      519           
=======================================
  Hits          434      434           
  Misses         85       85           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@erisu
Copy link
Member Author

erisu commented Apr 10, 2024

Closing out as the changes are merged with PR #270

@erisu erisu closed this Apr 10, 2024
@erisu erisu deleted the ci/update-codecov branch April 10, 2024 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants