Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HooksRunner code & spec cleanup #796

Merged
merged 3 commits into from
Oct 10, 2019
Merged

Conversation

raphinesse
Copy link
Contributor

@raphinesse raphinesse commented Oct 9, 2019

Motivation and Context

Aside from general code quality improvement, this serves to pave the way for #770.

Description

No functional changes

Testing

Ran automated tests

@raphinesse raphinesse added this to the 9.0.2 milestone Oct 9, 2019
@raphinesse raphinesse requested a review from erisu October 9, 2019 15:32
@project-bot project-bot bot added this to 🐣 New PR / Untriaged in Apache Cordova: Tooling Pull Requests Oct 9, 2019
Copy link
Member

@erisu erisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

I added on comment with one suggestion. If its no required then can be ignored.

src/hooks/HooksRunner.js Show resolved Hide resolved
Apache Cordova: Tooling Pull Requests automation moved this from 🐣 New PR / Untriaged to ✅ Approved, waiting for Merge Oct 10, 2019
@raphinesse raphinesse merged commit 7f66885 into apache:master Oct 10, 2019
Apache Cordova: Tooling Pull Requests automation moved this from ✅ Approved, waiting for Merge to 🏆 Merged, waiting for Release Oct 10, 2019
@raphinesse raphinesse deleted the hr-cleanup branch October 10, 2019 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Apache Cordova: Tooling Pull Requests
🏆 Merged, waiting for Release
Development

Successfully merging this pull request may close these issues.

None yet

2 participants