Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(android) reference emulator from node_modules #214

Merged

Conversation

zachawilson
Copy link
Contributor

Platforms affected

  • Android when using cordova-android@10+

Motivation and Context

apache/cordova-android#1269

Description

Since the emulator script is no longer copied into the platform, this updates the path to reference the script in the node_modules folder

Testing

I have run the cordova-paramedic command targeting android and the file not found error is resolved.
This has been run targeting android@10.1.0 on macos@11.4 and using GitHub Actions.
Backwards compatibility (pre android@10) has been confirmed to work by running npm test

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

Copy link
Contributor

@breautek breautek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@erisu erisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@erisu erisu merged commit 8ca66d8 into apache:master Aug 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants