DELTASPIKE-1473: Improved dependency consistency in the JSF module #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tandraschko
reviewed
May 10, 2024
deltaspike/modules/jsf/pom.xml
Outdated
| @@ -39,6 +39,62 @@ | |||
| <module>impl</module> | |||
| </modules> | |||
|
|
|||
| <build> | |||
There was a problem hiding this comment.
if you remove this (enforcer + maven-dependency-plugin), i would merge it
we never had this and we would need a discussion; i'm not a fan of it.
There was a problem hiding this comment.
Hi @tandraschko,
I just removed the changes to the POMs in parent and modules/jsf.
If anyone likes the idea of enforcing those consistency rules, the proposed changes are still available in https://github.com/cmunier/deltaspike/tree/DELTASPIKE-1473-enforce-consistency.
I have had a good experience with using both enforced scopes and especially "dependency analyze" in several projects, as it is a measure that is low-effort and can be used selectively in part of a multi-module project.
- removed obsolete dependencies - added used transitive dependencies as explicite dependencies - narrowed down dependency scopes that were too broad
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/DELTASPIKE-1473