Fix switch js, add black key (#15680)

Co-authored-by: fuchanghai <changhaifu@apache.org> Co-authored-by: Eric Gao <ericgao.apache@gmail.com>
apache · Mar 18, 2024 · 4a255fd · 4a255fd
1 parent faa794c
commit 4a255fd
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/...master/src/main/java/org/apache/dolphinscheduler/server/master/utils/SwitchTaskUtils.java b/...master/src/main/java/org/apache/dolphinscheduler/server/master/utils/SwitchTaskUtils.java
@@ -50,6 +50,10 @@ public class SwitchTaskUtils {
             "eval",
             "function",
             "import",
+            ".",
+            "()",
+            "[",
+            "]",
             "\\\\");
 
     static {

diff --git a/...er/src/test/java/org/apache/dolphinscheduler/server/master/utils/SwitchTaskUtilsTest.java b/...er/src/test/java/org/apache/dolphinscheduler/server/master/utils/SwitchTaskUtilsTest.java
@@ -65,5 +65,15 @@ public void testIllegalCondition() {
             SwitchTaskUtils.generateContentWithTaskParams(contentWithUnicode, globalParams, varParams);
         });
 
+        String contentWithSpecify1 = "cmd.abc";
+        Assertions.assertThrowsExactly(IllegalArgumentException.class, () -> {
+            SwitchTaskUtils.generateContentWithTaskParams(contentWithSpecify1, globalParams, varParams);
+        });
+
+        String contentWithSpecify2 = "cmd()";
+        Assertions.assertThrowsExactly(IllegalArgumentException.class, () -> {
+            SwitchTaskUtils.generateContentWithTaskParams(contentWithSpecify2, globalParams, varParams);
+        });
+
     }
 }