[Improvement][Master] Add Quartz Enable Control #15985
Open
+13
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pegasas
requested review from
caishunfeng,
SbloodyS and
ruanwenjun
as code owners
ruanwenjun
requested changes
May 12, 2024
...inscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/MasterServer.java
Outdated
Show resolved
Hide resolved
ruanwenjun
reviewed
May 12, 2024
Radeity
reviewed
May 12, 2024
Radeity
reviewed
May 12, 2024
...uler-master/src/main/java/org/apache/dolphinscheduler/server/master/config/MasterConfig.java
Outdated
Show resolved
Hide resolved
Update dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/MasterServer.java Co-authored-by: Wenjun Ruan <wenjun@apache.org> Update dolphinscheduler-master/src/main/resources/application.yaml Co-authored-by: Wenjun Ruan <wenjun@apache.org> fix comments
Co-authored-by: Wenjun Ruan <wenjun@apache.org>
Co-authored-by: Aaron Wang <wangweirao16@gmail.com>
rickchengx
reviewed
May 15, 2024
| @@ -120,7 +124,9 @@ public void run() throws SchedulerException { | |||
| this.eventExecuteService.start(); | |||
| this.failoverExecuteThread.start(); | |||
|
|
|||
| this.schedulerApi.start(); | |||
| if (masterConfig.isSchedulerEnabled()) { | |||
There was a problem hiding this comment.
Every time this config is modified, the master needs to be restarted. I don't quite understand under what circumstances the master's scheduling needs to be turned off, and whether this will cause other potential problems.
Would you please describe more about the usage scenarios of this config?
…ler/server/master/config/MasterConfig.java Co-authored-by: Aaron Wang <wangweirao16@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
resolve: #15984
Brief change log
add quartz enable control for the scenario that we wants to gray release some feature.
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md