-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Improvement][Master] Add Quartz Enable Control #15985
base: dev
Are you sure you want to change the base?
Conversation
...inscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/MasterServer.java
Outdated
Show resolved
Hide resolved
...uler-master/src/main/java/org/apache/dolphinscheduler/server/master/config/MasterConfig.java
Outdated
Show resolved
Hide resolved
Update dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/MasterServer.java Co-authored-by: Wenjun Ruan <wenjun@apache.org> Update dolphinscheduler-master/src/main/resources/application.yaml Co-authored-by: Wenjun Ruan <wenjun@apache.org> fix comments
Co-authored-by: Wenjun Ruan <wenjun@apache.org>
Co-authored-by: Aaron Wang <wangweirao16@gmail.com>
@@ -120,7 +124,9 @@ public void run() throws SchedulerException { | |||
this.eventExecuteService.start(); | |||
this.failoverExecuteThread.start(); | |||
|
|||
this.schedulerApi.start(); | |||
if (masterConfig.isSchedulerEnabled()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Every time this config is modified, the master needs to be restarted. I don't quite understand under what circumstances the master's scheduling needs to be turned off, and whether this will cause other potential problems.
Would you please describe more about the usage scenarios of this config?
…ler/server/master/config/MasterConfig.java Co-authored-by: Aaron Wang <wangweirao16@gmail.com>
Purpose of the pull request
resolve: #15984
Brief change log
add quartz enable control for the scenario that we wants to gray release some feature.
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md