Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug][ui] fix ui Failed to query list after editing file #15647

Open
wants to merge 30 commits into
base: dev
Choose a base branch
from

Conversation

bajiaolong
Copy link

fix: #15644

Purpose of the pull request

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@github-actions github-actions bot added the UI ui and front end related label Feb 28, 2024
@bajiaolong bajiaolong changed the title [Fix][api]Unable to return to the parent directory after modifying the resource file [Fix][ui]Unable to return to the parent directory after modifying the resource file Feb 28, 2024
@bajiaolong bajiaolong changed the title [Fix][ui]Unable to return to the parent directory after modifying the resource file [Fix][ui] fix ui Failed to query list after editing file Feb 28, 2024
@qingwli qingwli added first time contributor First-time contributor bug Something isn't working labels Feb 28, 2024
@qingwli qingwli modified the milestones: 3.1.10, 3.2.2 Feb 28, 2024
@codecov-commenter
Copy link

codecov-commenter commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.86%. Comparing base (ace20f9) to head (794ffb1).

❗ Current head 794ffb1 differs from pull request most recent head 21304bb. Consider uploading reports for the commit 21304bb to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##                dev   #15647   +/-   ##
=========================================
  Coverage     39.86%   39.86%           
- Complexity     5060     5064    +4     
=========================================
  Files          1369     1369           
  Lines         45635    45635           
  Branches       4869     4868    -1     
=========================================
  Hits          18193    18193           
  Misses        25544    25544           
  Partials       1898     1898           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@songjianet songjianet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@bajiaolong bajiaolong changed the title [Fix][ui] fix ui Failed to query list after editing file [bug][ui] fix ui Failed to query list after editing file Mar 4, 2024
songjianet
songjianet previously approved these changes Mar 5, 2024
SbloodyS
SbloodyS previously approved these changes Mar 11, 2024
Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

rickchengx
rickchengx previously approved these changes Mar 12, 2024
@bajiaolong
Copy link
Author

This will be fixed after this pr is merged. #15732 @bajiaolong

RECD

@rickchengx
Copy link
Contributor

@bajiaolong it seems CI cannot pass
image

Copy link

sonarcloud bot commented May 10, 2024

Please retry analysis of this Pull-Request directly on SonarCloud

@SbloodyS
Copy link
Member

@rickchengx @ruanwenjun @EricGao888 PTAL.

@EricGao888
Copy link
Member

@rickchengx @ruanwenjun @EricGao888 PTAL.

I'm not familiar with front-end stuff. Would u plz take a look? @arlendp @c3Vu

Copy link
Contributor

@rickchengx rickchengx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.2.2 bug Something isn't working first time contributor First-time contributor ready-to-merge UI ui and front end related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] [API] edit file in resource center and do nothing exit will recive err
8 participants