Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: modify some CODEOWNERS #15654

Merged
merged 3 commits into from Mar 4, 2024
Merged

chore: modify some CODEOWNERS #15654

merged 3 commits into from Mar 4, 2024

Conversation

zhongjiajie
Copy link
Member

I'll be away from the community for a while, and I've removed me from the codeowner configurations to reduce notification for my mailbox

@github-actions github-actions bot added the CI&CD label Feb 29, 2024
zhongjiajie
zhongjiajie commented Feb 29, 2024
View reviewed changes
.github/CODEOWNERS Outdated
@@ -23,7 +23,7 @@
/dolphinscheduler-registry/ @caishunfeng @ruanwenjun
/dolphinscheduler-api/ @caishunfeng @SbloodyS
/dolphinscheduler-dao/ @caishunfeng @SbloodyS
/dolphinscheduler-dao/src/main/resources/sql/ @zhongjiajie
/dolphinscheduler-dao/src/main/resources/sql/
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did some of our team interested be new code owner for /dolphinscheduler-dao/src/main/resources/sql/ module?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about @EricGao888 ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will add one more commit and assign those to you 💯

.github/CODEOWNERS Outdated
/licenses/ @zhongjiajie
/images/ @zhongjiajie @EricGao888
/docs/ @EricGao888
/licenses/
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did some of our team interested be new code owner for /licenses/ directory?

SbloodyS
SbloodyS previously approved these changes Feb 29, 2024
View reviewed changes
Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SbloodyS SbloodyS added this to the 3.2.2 milestone Feb 29, 2024
@SbloodyS SbloodyS added improvement make more easy to user or prompt friendly chore and removed improvement make more easy to user or prompt friendly labels Feb 29, 2024
ruanwenjun
ruanwenjun previously approved these changes Mar 1, 2024
View reviewed changes
Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@zhongjiajie zhongjiajie added the help wanted Extra attention is needed label Mar 1, 2024
caishunfeng
caishunfeng previously approved these changes Mar 1, 2024
View reviewed changes
Copy link
Contributor

@caishunfeng caishunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.58%. Comparing base (3fda980) to head (a027ef7).

❗ Current head a027ef7 differs from pull request most recent head 93cd09d. Consider uploading reports for the commit 93cd09d to get more accurate results

Additional details and impacted files 
@@             Coverage Diff              @@
##                dev   #15654      +/-   ##
============================================
+ Coverage     38.57%   38.58%   +0.01%     
- Complexity     4792     4794       +2     
============================================
  Files          1316     1316              
  Lines         45043    45043              
  Branches       4823     4823              
============================================
+ Hits          17374    17382       +8     
+ Misses        25779    25769      -10     
- Partials       1890     1892       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ruanwenjun ruanwenjun added minor Chore Chores about the project, like code clean, typo, etc. and removed chore labels Mar 1, 2024
@zhongjiajie zhongjiajie removed the help wanted Extra attention is needed label Mar 2, 2024
@SbloodyS SbloodyS added the chore label Mar 4, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 4, 2024

Please retry analysis of this Pull-Request directly on SonarCloud

@SbloodyS SbloodyS merged commit 48ea8f3 into apache:dev Mar 4, 2024
55 of 56 checks passed
@zhongjiajie zhongjiajie deleted the chg-codeowner branch March 4, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EricGao888 EricGao888 EricGao888 left review comments

@rickchengx rickchengx rickchengx approved these changes

@caishunfeng caishunfeng caishunfeng left review comments

@SbloodyS SbloodyS SbloodyS left review comments

@ruanwenjun ruanwenjun ruanwenjun left review comments

Assignees

@zhongjiajie zhongjiajie

Labels
3.2.2 chore CI&CD minor Chore Chores about the project, like code clean, typo, etc. ready-to-merge
Projects
None yet
Milestone
3.2.2
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@zhongjiajie @codecov-commenter @caishunfeng @SbloodyS @ruanwenjun @EricGao888 @rickchengx