[TEST] fix log server related test #15659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abzymeinsjtu
force-pushed
the
test_fix_log_service_port_binded
branch
from
f339c73
to
3a18cbc
Compare
EricGao888
previously approved these changes
Mar 2, 2024
|
Looks like there are some style issues which cause CI to fail, plz run Others LGTM
|
abzymeinsjtu
force-pushed
the
test_fix_log_service_port_binded
branch
from
8422d44
to
37401a7
Compare
fixed |
EricGao888
approved these changes
Mar 2, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #15659 +/- ##
======================================
Coverage ? 38.54%
Complexity ? 4783
======================================
Files ? 1316
Lines ? 44968
Branches ? 4816
======================================
Hits ? 17333
Misses ? 25755
Partials ? 1880 ☔ View full report in Codecov by Sentry. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
Case in LoggerServerTest will fail when port 8080 is already used by other process, try start with a random port instead