[Improvement-15690][shell_task] Shell task to have Workflow instance #15691
Conversation
…specific attributes for the use - TaskExecutionContext to have the processName and processInstanceName - TaskExecutionContextBuilder to have the processName and processInstanceName Variables - ShellTask to have the attributes replaced - WORKFLOW_NAME - WORKFLOW_INSTANCE_NAME - WORKFLOW_ID - WORKFLOW_INSTANCE_ID This closed Improvement-15690
baratamavinash225
requested review from
caishunfeng,
SbloodyS,
zhuangchong and
ruanwenjun
as code owners
There was a problem hiding this comment.
Please change your target branch to dev and link pr to your issue. @baratamavinash225
| if(paramUtilsMap != null) { | ||
| map.putAll(paramUtilsMap); | ||
| } | ||
| map.put("WORKFLOW_NAME", taskExecutionContext.getProcessDefinitionName()); |
There was a problem hiding this comment.
If it is a built-in variable, I think it should be the same for all task types (not only shell).
And I'm not sure about the benefits of these built-in variables, could you please give some examples?
Furthermore, relevant docs and UT should be added.
There was a problem hiding this comment.
I have found useful for my use case. We are integrating the flows with the Splunk logs. While logging for the splunk events we are mapping this variable so that we can filter the logs in splunk at the workflow instance level.
Hence, we are using this. Reason we are pushing to splunk is we are not giving the dolphin UI to Users, instead we are giving a utility to run/schedule the jobs in the scheduler.
There was a problem hiding this comment.
@baratamavinash225 The built-in parameters should be valid for all tasks, so I suggest you start a discussion on the mailing list.
…specific attributes for the use
This closed Improvement-15690
Purpose of the pull request
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md