Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] Remove unused method #15743

Merged
merged 2 commits into from Mar 21, 2024

Conversation

EricGao888
Copy link
Member

Purpose of the pull request

  • queryLastRunningProcess is no more used, we could remove it.

@codecov-commenter
Copy link

codecov-commenter commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.09%. Comparing base (49d04de) to head (dfaf872).

❗ Current head dfaf872 differs from pull request most recent head 848f48f. Consider uploading reports for the commit 848f48f to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##                dev   #15743   +/-   ##
=========================================
  Coverage     39.08%   39.09%           
- Complexity     4850     4851    +1     
=========================================
  Files          1316     1316           
  Lines         44927    44963   +36     
  Branches       4786     4810   +24     
=========================================
+ Hits          17561    17578   +17     
- Misses        25466    25486   +20     
+ Partials       1900     1899    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EricGao888 EricGao888 added the improvement make more easy to user or prompt friendly label Mar 20, 2024
@EricGao888 EricGao888 self-assigned this Mar 20, 2024
Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@caishunfeng caishunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@SbloodyS
Copy link
Member

It seems like Frontend Build check did not trigger...I'll fix it.

Copy link

sonarcloud bot commented Mar 21, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@EricGao888 EricGao888 merged commit 023c22c into apache:dev Mar 21, 2024
60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend improvement make more easy to user or prompt friendly ready-to-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants