Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] change js engine #15747

Merged
merged 4 commits into from Mar 22, 2024
Merged

Conversation

caishunfeng
Copy link
Contributor

Purpose of the pull request

It seems the nashorn-sandbox is a better solution to avoid some security in js engine, see https://github.com/javadelight/delight-nashorn-sandbox.

Brief change log

dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/utils/SwitchTaskUtils.java

Verify this pull request

  • Update UT.
  • Manually verified the change by testing locally.

@caishunfeng caishunfeng self-assigned this Mar 20, 2024
@caishunfeng caishunfeng added improvement make more easy to user or prompt friendly 3.2.2 labels Mar 20, 2024
@ruanwenjun
Copy link
Member

license check failed.

@codecov-commenter
Copy link

codecov-commenter commented Mar 21, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 39.08%. Comparing base (f7358c3) to head (f080376).

❗ Current head f080376 differs from pull request most recent head 7d13d65. Consider uploading reports for the commit 7d13d65 to get more accurate results

Files Patch % Lines
...scheduler/server/master/utils/SwitchTaskUtils.java 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev   #15747      +/-   ##
============================================
- Coverage     39.11%   39.08%   -0.03%     
+ Complexity     4856     4851       -5     
============================================
  Files          1316     1316              
  Lines         44970    44964       -6     
  Branches       4811     4809       -2     
============================================
- Hits          17588    17574      -14     
- Misses        25481    25491      +10     
+ Partials       1901     1899       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Mar 21, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
50.0% Coverage on New Code (required ≥ 60%)

See analysis details on SonarCloud

Copy link
Member

@EricGao888 EricGao888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@caishunfeng caishunfeng merged commit 99a2461 into apache:dev Mar 22, 2024
59 of 61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.2.2 backend improvement make more easy to user or prompt friendly ready-to-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants