[Bug] Fix delay execution task will never be dispatched #15751
Conversation
ruanwenjun
changed the title
ruanwenjun
force-pushed
the
dev_wenjun_fixDelayExecution
branch
from
8354eea
to
c654b00
Compare
ruanwenjun
force-pushed
the
dev_wenjun_fixDelayExecution
branch
from
c654b00
to
0a56145
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #15751 +/- ##
============================================
- Coverage 39.08% 39.08% -0.01%
Complexity 4851 4851
============================================
Files 1316 1316
Lines 44964 44965 +1
Branches 4809 4809
============================================
- Hits 17574 17573 -1
- Misses 25491 25492 +1
- Partials 1899 1900 +1 ☔ View full report in Codecov by Sentry. |
| @@ -48,9 +48,10 @@ public void operate(DefaultTaskExecuteRunnable taskExecuteRunnable) { | |||
| if (remainTime > 0) { | |||
| taskInstance.setState(TaskExecutionStatus.DELAY_EXECUTION); | |||
| taskInstanceDao.updateById(taskInstance); | |||
| log.info("Current taskInstance: {} is choose delay execution, delay time: {}/s, remainTime: {}/s", | |||
| log.info("Current taskInstance: {} is choose delay execution, delay time: {}/min, remainTime: {}/s", | |||
There was a problem hiding this comment.
This looks a bit weird. Could we make the unit for delay time and remain time consistent? (all in second / all in minute)
There was a problem hiding this comment.
it's OK to log min here, since the input is min.
|
Purpose of the pull request
close #15750
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md