Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix-15828] fix expandListParameter #15878

Open
wants to merge 19 commits into
base: dev
Choose a base branch
from
Open

[Fix-15828] fix expandListParameter #15878

wants to merge 19 commits into from

Conversation

xxzuo
Copy link
Contributor

@xxzuo xxzuo commented Apr 18, 2024

Purpose of the pull request

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@ruanwenjun ruanwenjun added the bug Something isn't working label Apr 19, 2024
@ruanwenjun ruanwenjun added this to the 3.2.2 milestone Apr 19, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 23, 2024

Codecov Report

Attention: Patch coverage is 56.00000% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 39.62%. Comparing base (e9d8591) to head (d32f5c8).

❗ Current head d32f5c8 differs from pull request most recent head 3ce3730. Consider uploading reports for the commit 3ce3730 to get more accurate results

Files Patch % Lines
...dolphinscheduler/plugin/task/api/AbstractTask.java 0.00% 3 Missing ⚠️
...olphinscheduler/plugin/task/api/TaskConstants.java 0.00% 3 Missing ⚠️
...ache/dolphinscheduler/plugin/task/sql/SqlTask.java 0.00% 3 Missing ⚠️
...cheduler/plugin/task/api/utils/ParameterUtils.java 87.50% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev   #15878      +/-   ##
============================================
- Coverage     39.64%   39.62%   -0.02%     
+ Complexity     5023     5021       -2     
============================================
  Files          1349     1349              
  Lines         45593    45595       +2     
  Branches       4890     4888       -2     
============================================
- Hits          18074    18067       -7     
- Misses        25596    25605       +9     
  Partials       1923     1923              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xxzuo xxzuo requested a review from ruanwenjun May 16, 2024 01:12
Copy link

sonarcloud bot commented May 16, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
42.3% Coverage on New Code (required ≥ 60%)

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend bug Something isn't working priority:middle
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Parameter replace with ? will cause NPE
4 participants