-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix-15828] fix expandListParameter #15878
base: dev
Are you sure you want to change the base?
Conversation
...hinscheduler-task-sql/src/main/java/org/apache/dolphinscheduler/plugin/task/sql/SqlTask.java
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #15878 +/- ##
============================================
- Coverage 39.64% 39.62% -0.02%
+ Complexity 5023 5021 -2
============================================
Files 1349 1349
Lines 45593 45595 +2
Branches 4890 4888 -2
============================================
- Hits 18074 18067 -7
- Misses 25596 25605 +9
Partials 1923 1923 ☔ View full report in Codecov by Sentry. |
Quality Gate failedFailed conditions |
Purpose of the pull request
${}
instead of first replacing ${} with a?
and then processing the parameters based on the?
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md