Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]Supports dinky tasks to accept Prepare Params passed within a task or from a previous task #15947

Open
wants to merge 16 commits into
base: dev
Choose a base branch
from
Open

[Feature]Supports dinky tasks to accept Prepare Params passed within a task or from a previous task #15947

wants to merge 16 commits into from

Conversation

gaoyan1998
Copy link

Purpose of the pull request

Supports dinky tasks to accept variables passed within a task or from a previous task

Brief change log

Verify this pull request

@gaoyan1998 gaoyan1998 changed the title Supports dinky tasks to accept Prepare Params passed within a task or from a previous task [Feature]Supports dinky tasks to accept Prepare Params passed within a task or from a previous task May 6, 2024
@ruanwenjun ruanwenjun added the improvement make more easy to user or prompt friendly label May 6, 2024
@ruanwenjun ruanwenjun added this to the 3.2.2 milestone May 6, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 6, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.67%. Comparing base (ec01df1) to head (9c0d6fd).
Report is 1 commits behind head on dev.

❗ Current head 9c0d6fd differs from pull request most recent head e75a80c

Please upload reports for the commit e75a80c to get more accurate results.

Additional details and impacted files 
@@            Coverage Diff            @@
##                dev   #15947   +/-   ##
=========================================
  Coverage     40.67%   40.67%           
  Complexity     5238     5238           
=========================================
  Files          1382     1382           
  Lines         46023    46023           
  Branches       4922     4922           
=========================================
  Hits          18719    18719           
  Misses        25379    25379           
  Partials       1925     1925

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SbloodyS SbloodyS added feature new feature first time contributor First-time contributor miss:docs missing documents in PR 3.2.2 labels May 6, 2024
SbloodyS
SbloodyS reviewed May 6, 2024
View reviewed changes
Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please supplement the document. @gaoyan1998

@gaoyan1998
Copy link
Author

Please supplement the document. @gaoyan1998

@SbloodyS PTAL, Supplement the documentation done.

@SbloodyS SbloodyS removed the miss:docs missing documents in PR label May 7, 2024
@SbloodyS
Copy link
Member

SbloodyS commented May 8, 2024

Please run mvn spotless:apply to format the code. @gaoyan1998

@gaoyan1998
Copy link
Author

Please run mvn spotless:apply to format the code. @gaoyan1998

I have resolved it，please review it，thanks. @SbloodyS

@gaoyan1998
Copy link
Author

@ruanwenjun Thanks for your suggestion, I have finished the revision

ruanwenjun
ruanwenjun previously approved these changes May 14, 2024
View reviewed changes
Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gaoyan1998 and others added 5 commits May 14, 2024 21:29
@gaoyan1998 @ruanwenjun
fix dinky unresolve params
1d57f6b
@gaoyan1998 @ruanwenjun
Supplement the Dinky documentation
3f39476
@gaoyan1998 @ruanwenjun
formate doc code
11d1fc6
@gaoyan1998 @ruanwenjun
Update dolphinscheduler-task-plugin/dolphinscheduler-task-dinky/src/m…
bae38af 
…ain/java/org/apache/dolphinscheduler/plugin/task/dinky/DinkyTask.java

Co-authored-by: Wenjun Ruan <wenjun@apache.org>
@gaoyan1998 @ruanwenjun
Update dolphinscheduler-task-plugin/dolphinscheduler-task-dinky/src/m…
2902943 
…ain/java/org/apache/dolphinscheduler/plugin/task/dinky/DinkyTask.java

Co-authored-by: Wenjun Ruan <wenjun@apache.org>
@gaoyan1998
Merge remote-tracking branch 'ikiler/fix-dinky-params' into fix-dinky…
30307eb 
…-params

# Conflicts:
#	dolphinscheduler-task-plugin/dolphinscheduler-task-dinky/src/main/java/org/apache/dolphinscheduler/plugin/task/dinky/DinkyTask.java
@gaoyan1998
fix import lost error
7e4ee87
@gaoyan1998
Copy link
Author

hi @ruanwenjun PTAL ,please approval workflows

@ruanwenjun ruanwenjun added 3.3.0 and removed 3.2.2 labels May 29, 2024
@ruanwenjun ruanwenjun modified the milestones: 3.2.2, 3.3.0 May 29, 2024
ruanwenjun
ruanwenjun approved these changes May 29, 2024
View reviewed changes
Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 29, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SbloodyS SbloodyS SbloodyS left review comments

@ruanwenjun ruanwenjun ruanwenjun approved these changes

@caishunfeng caishunfeng Awaiting requested review from caishunfeng caishunfeng is a code owner

@zhuangchong zhuangchong Awaiting requested review from zhuangchong zhuangchong is a code owner

@EricGao888 EricGao888 Awaiting requested review from EricGao888 EricGao888 is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees

@gaoyan1998 gaoyan1998

Labels
3.3.0 backend document feature new feature first time contributor First-time contributor improvement make more easy to user or prompt friendly priority:high
Projects
None yet
Milestone
3.3.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gaoyan1998 @codecov-commenter @SbloodyS @ruanwenjun