when use list as out property in sql tasks, if sql result has only one row, still wrap result in a list #15972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…apache#15540) * Reduce the size of tarball to continue ASF release for more detail you can see https://lists.apache.org/thread/rmp7fghlj0n7h9y2v3p8gkw9f9qbo6qt
(cherry picked from commit 25810a8)
Co-authored-by: fuchanghai <changhaifu@apache.org> (cherry picked from commit 2f66a66)
…ime (apache#15528) (cherry picked from commit 8974233)
Co-authored-by: xiangzihao <460888207@qq.com> Co-authored-by: Eric Gao <ericgao.apache@gmail.com> (cherry picked from commit 1b42d45)
(cherry picked from commit 4d15932)
* fix: data quality can not use fix: apache#15468, apache#15249, apache#14858 --------- Co-authored-by: Rick Cheng <rickchengx@gmail.com> Co-authored-by: Eric Gao <ericgao.apache@gmail.com> (cherry picked from commit 8efaa9f)
Co-authored-by: Rick Cheng <rickchengx@gmail.com> Co-authored-by: Eric Gao <ericgao.apache@gmail.com> (cherry picked from commit ef9ed3d)
…on MacOS in ProcessUtilsTest (apache#15480) (apache#15529) Co-authored-by: Rick Cheng <rickchengx@gmail.com> (cherry picked from commit 4d6af51)
Co-authored-by: Rick Cheng <rickchengx@gmail.com> (cherry picked from commit d8e820c)
Co-authored-by: Rick Cheng <rickchengx@gmail.com> (cherry picked from commit e5a208f)
* fix: start param for wf not work fix: apache#15280 * fix test (cherry picked from commit 01eb8f8)
(cherry picked from commit 91d56f4)
…ccess but task insatnce is killed/paused (apache#15574) (cherry picked from commit 43a0652)
Co-authored-by: fuchanghai <changhaifu@apache.org> Co-authored-by: Eric Gao <ericgao.apache@gmail.com> Co-authored-by: Rick Cheng <rickchengx@gmail.com> (cherry picked from commit 69676b4)
…ache#15576) Co-authored-by: Rick Cheng <rickchengx@gmail.com> (cherry picked from commit 4541e74)
…ception. (apache#15577) (cherry picked from commit 73a5a77)
…on in the worker (apache#15565) Co-authored-by: Rick Cheng <rickchengx@gmail.com> (cherry picked from commit 89da67d)
* fix can not get correct resource related path when user run workflow with differnet tenant of resource created * also fix can not get correct related path when we use `resource.storage.type=LOCAL` (cherry picked from commit bd83631)
* Revert "Fix k8sTaskExecutionContext setting configYaml (apache#15116)" This reverts commit ce11674. * Revert "[Improvement] Refactoring K8S task plugin with connections managed in connection center (apache#14977)" This reverts commit c532fea.
…e row, still wrap result in a list; if sql result has no row, use property value as default and wrap it in a list
HouSong
requested review from
caishunfeng,
SbloodyS and
zhuangchong
as code owners
SbloodyS
requested changes
May 10, 2024
HouSong
requested review from
EricGao888,
songjianet,
Amy0104 and
ruanwenjun
as code owners
I haven't created an issue for this PR. Is it required? |
|
Please rebase latest dev. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #15972 +/- ##
============================================
+ Coverage 38.15% 38.49% +0.33%
- Complexity 4707 4752 +45
============================================
Files 1304 1301 -3
Lines 44828 44781 -47
Branches 4807 4809 +2
============================================
+ Hits 17105 17237 +132
+ Misses 25870 25663 -207
- Partials 1853 1881 +28 ☔ View full report in Codecov by Sentry. |
|
Please retry analysis of this Pull-Request directly on SonarCloud |
|
There seems to be some conflict, please pull the upstream dev code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
when use list as out property in sql tasks, if sql result has only one row, there will be an exception.
In this PR, when use list as out property in sql tasks, if sql result has only one row, this result will be wrapped in a list; if sql result has no row, use property value as default and wrap it in a list (if property value exists) .
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md