-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix-15992] maintain slot index by iterate MasterPriorityQueue orderly #15993
Conversation
...ler-service/src/main/java/org/apache/dolphinscheduler/service/queue/MasterPriorityQueue.java
Outdated
Show resolved
Hide resolved
...ler-service/src/main/java/org/apache/dolphinscheduler/service/queue/MasterPriorityQueue.java
Outdated
Show resolved
Hide resolved
...service/src/test/java/org/apache/dolphinscheduler/service/queue/MasterPriorityQueueTest.java
Outdated
Show resolved
Hide resolved
Please fix the code style by |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #15993 +/- ##
============================================
+ Coverage 39.91% 40.43% +0.52%
- Complexity 5083 5184 +101
============================================
Files 1370 1379 +9
Lines 45649 46093 +444
Branches 4869 4924 +55
============================================
+ Hits 18223 18640 +417
+ Misses 25527 25526 -1
- Partials 1899 1927 +28 ☔ View full report in Codecov by Sentry. |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Purpose of the pull request
fix #15992
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md