Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](test)Add wait for full compaction #34706

Merged
merged 1 commit into from May 13, 2024

Conversation

qidaye
Copy link
Contributor

@qidaye qidaye commented May 11, 2024

Proposed changes

test_index_compaction_fault_injection case is unstable.
Add wait to check full compaction is done before assert.

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@qidaye
Copy link
Contributor Author

qidaye commented May 11, 2024

run buildall

Copy link
Contributor

@xiaokang xiaokang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label May 11, 2024
Copy link
Contributor

PR approved by at least one committer and no changes requested.

Copy link
Contributor

PR approved by anyone and no changes requested.

Copy link
Member

@eldenmoon eldenmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qidaye qidaye merged commit df932af into apache:master May 13, 2024
27 of 29 checks passed
@qidaye qidaye deleted the fix_index_compaction_case branch May 13, 2024 02:54
M1saka2003 pushed a commit to M1saka2003/doris that referenced this pull request May 14, 2024
`test_index_compaction_fault_injection` case is unstable. 
Add wait to check full compaction is done before assert.

Co-authored-by: Luennng <luennng@gmail.com>
ByteYue pushed a commit to ByteYue/doris that referenced this pull request May 15, 2024
`test_index_compaction_fault_injection` case is unstable. 
Add wait to check full compaction is done before assert.

Co-authored-by: Luennng <luennng@gmail.com>
M1saka2003 pushed a commit to M1saka2003/doris that referenced this pull request May 24, 2024
`test_index_compaction_fault_injection` case is unstable. 
Add wait to check full compaction is done before assert.

Co-authored-by: Luennng <luennng@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants