Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix clang-18 and libc++ compile problems #34715

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

biohazard4321
Copy link

Proposed changes

Issue Number: close #xxx

Fix clang-18 and libc++ compile problems

unique() of shared_ptr is deprecated in clang-18, it's not a strict implementation, can use use_count() instead.
And fixed some other compie errors in both using clang-18 and libc++.

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@gavinchou
Copy link
Collaborator

LGTM

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@biohazard4321
Copy link
Author

please approval

@biohazard4321
Copy link
Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 40660 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit f2ddbda309effa3d29f6d3778004bba477f7764a, data reload: false

------ Round 1 ----------------------------------
q1	17893	4550	4315	4315
q2	2026	181	191	181
q3	10489	1239	1105	1105
q4	10144	812	831	812
q5	7493	2699	2643	2643
q6	213	131	132	131
q7	979	574	583	574
q8	9249	2095	2067	2067
q9	8851	6608	6530	6530
q10	8833	3694	3694	3694
q11	441	242	239	239
q12	476	215	216	215
q13	17784	2946	2954	2946
q14	247	213	226	213
q15	516	481	474	474
q16	506	398	384	384
q17	975	732	753	732
q18	8087	7454	7467	7454
q19	2802	1538	1515	1515
q20	645	305	303	303
q21	4990	3853	4022	3853
q22	362	285	280	280
Total cold run time: 114001 ms
Total hot run time: 40660 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4360	4313	4234	4234
q2	381	268	270	268
q3	2989	2822	2760	2760
q4	1899	1611	1617	1611
q5	5317	5300	5303	5300
q6	214	127	126	126
q7	2226	1880	1915	1880
q8	3237	3351	3360	3351
q9	8387	8380	8400	8380
q10	3891	3651	3692	3651
q11	596	484	499	484
q12	750	591	594	591
q13	16425	2924	2957	2924
q14	282	262	259	259
q15	520	466	473	466
q16	469	422	415	415
q17	1780	1509	1486	1486
q18	7788	7740	7588	7588
q19	1661	1541	1596	1541
q20	1952	1786	1759	1759
q21	4914	4741	4977	4741
q22	556	514	500	500
Total cold run time: 70594 ms
Total hot run time: 54315 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 188104 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit f2ddbda309effa3d29f6d3778004bba477f7764a, data reload: false

query1	904	387	361	361
query2	6457	2599	2281	2281
query3	6671	215	218	215
query4	22636	21357	21334	21334
query5	4221	417	432	417
query6	263	177	168	168
query7	4601	287	282	282
query8	243	186	184	184
query9	8749	2391	2387	2387
query10	443	243	262	243
query11	14759	14161	14206	14161
query12	139	93	92	92
query13	1648	368	373	368
query14	10599	8517	8520	8517
query15	255	170	173	170
query16	8181	288	249	249
query17	1846	549	542	542
query18	2098	270	263	263
query19	261	151	146	146
query20	89	85	87	85
query21	194	132	135	132
query22	5134	4804	4895	4804
query23	34027	33796	33548	33548
query24	12089	2887	2932	2887
query25	648	358	372	358
query26	1762	159	153	153
query27	3030	319	332	319
query28	7663	2048	2053	2048
query29	1026	622	602	602
query30	313	178	178	178
query31	1002	761	728	728
query32	92	53	54	53
query33	743	239	244	239
query34	1082	481	468	468
query35	808	672	686	672
query36	1060	919	905	905
query37	280	68	72	68
query38	2901	2763	2786	2763
query39	1618	1537	1546	1537
query40	272	125	125	125
query41	46	43	43	43
query42	106	97	118	97
query43	574	576	546	546
query44	1205	731	737	731
query45	259	260	256	256
query46	1075	713	695	695
query47	1961	1857	1893	1857
query48	379	312	296	296
query49	1170	384	388	384
query50	771	373	385	373
query51	6886	6762	6815	6762
query52	107	93	95	93
query53	358	289	281	281
query54	973	422	449	422
query55	74	74	74	74
query56	240	226	217	217
query57	1250	1156	1157	1156
query58	216	222	202	202
query59	3499	3218	3282	3218
query60	255	226	240	226
query61	85	85	85	85
query62	642	471	457	457
query63	315	281	281	281
query64	9758	7464	7407	7407
query65	3101	3105	3060	3060
query66	1364	346	346	346
query67	15521	15150	15090	15090
query68	4564	528	534	528
query69	479	299	300	299
query70	1165	1126	1115	1115
query71	405	265	270	265
query72	7273	2524	2403	2403
query73	697	317	316	316
query74	6568	6057	6111	6057
query75	3419	2628	2636	2628
query76	2947	953	1012	953
query77	400	262	261	261
query78	10658	10164	10043	10043
query79	2142	537	525	525
query80	921	459	522	459
query81	524	254	238	238
query82	657	97	97	97
query83	230	170	171	170
query84	233	86	86	86
query85	1872	270	269	269
query86	513	274	303	274
query87	3227	3123	3073	3073
query88	4119	2321	2312	2312
query89	466	394	395	394
query90	1989	189	183	183
query91	122	99	95	95
query92	57	49	49	49
query93	2322	510	488	488
query94	1266	180	193	180
query95	394	304	294	294
query96	590	273	260	260
query97	3155	3055	2969	2969
query98	232	219	215	215
query99	1157	906	899	899
Total cold run time: 287760 ms
Total hot run time: 188104 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.73 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit f2ddbda309effa3d29f6d3778004bba477f7764a, data reload: false

query1	0.04	0.03	0.03
query2	0.07	0.04	0.04
query3	0.23	0.05	0.05
query4	1.67	0.07	0.07
query5	0.49	0.48	0.50
query6	1.13	0.74	0.72
query7	0.02	0.01	0.01
query8	0.06	0.05	0.04
query9	0.53	0.50	0.51
query10	0.54	0.54	0.54
query11	0.15	0.11	0.12
query12	0.14	0.11	0.11
query13	0.58	0.59	0.60
query14	0.77	0.78	0.78
query15	0.82	0.80	0.81
query16	0.34	0.37	0.38
query17	0.94	0.99	0.99
query18	0.22	0.24	0.25
query19	1.76	1.70	1.67
query20	0.01	0.01	0.01
query21	15.43	0.72	0.67
query22	4.36	7.08	2.16
query23	18.27	1.48	1.34
query24	1.51	0.32	0.22
query25	0.14	0.09	0.08
query26	0.27	0.17	0.17
query27	0.07	0.08	0.08
query28	13.43	1.02	1.00
query29	13.17	3.25	3.27
query30	0.24	0.06	0.06
query31	2.89	0.39	0.39
query32	3.26	0.46	0.48
query33	2.81	2.84	2.86
query34	17.27	4.37	4.48
query35	4.51	4.44	4.51
query36	0.65	0.47	0.47
query37	0.16	0.15	0.15
query38	0.16	0.14	0.15
query39	0.04	0.04	0.03
query40	0.17	0.14	0.14
query41	0.10	0.04	0.04
query42	0.05	0.05	0.05
query43	0.04	0.03	0.04
Total cold run time: 109.51 s
Total hot run time: 30.73 s

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 35.67% (8982/25180)
Line Coverage: 27.33% (74258/271741)
Region Coverage: 26.56% (38371/144444)
Branch Coverage: 23.38% (19568/83696)
Coverage Report: http://coverage.selectdb-in.cc/coverage/f2ddbda309effa3d29f6d3778004bba477f7764a_f2ddbda309effa3d29f6d3778004bba477f7764a/report/index.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants