New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] Fix clang-18 and libc++ compile problems #34715
base: master
Are you sure you want to change the base?
Conversation
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
LGTM |
clang-tidy review says "All clean, LGTM! 👍" |
please approval |
run buildall |
TPC-H: Total hot run time: 40660 ms
|
TPC-DS: Total hot run time: 188104 ms
|
ClickBench: Total hot run time: 30.73 s
|
TeamCity be ut coverage result: |
Proposed changes
Issue Number: close #xxx
Fix clang-18 and libc++ compile problems
unique() of shared_ptr is deprecated in clang-18, it's not a strict implementation, can use use_count() instead.
And fixed some other compie errors in both using clang-18 and libc++.
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...