Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enhancement](regression-test) modify a key type tests #34717

Merged
merged 4 commits into from May 17, 2024

Conversation

cjj2010
Copy link
Contributor

@cjj2010 cjj2010 commented May 11, 2024

Proposed changes

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@cjj2010
Copy link
Contributor Author

cjj2010 commented May 11, 2024

run buildall

dataroaring
dataroaring previously approved these changes May 11, 2024
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels May 11, 2024
Copy link
Contributor

PR approved by anyone and no changes requested.

@cjj2010
Copy link
Contributor Author

cjj2010 commented May 13, 2024

run buildall

@cjj2010
Copy link
Contributor Author

cjj2010 commented May 14, 2024

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label May 14, 2024
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 7abc516 into apache:master May 17, 2024
26 of 27 checks passed
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label May 17, 2024
Copy link
Contributor

PR approved by at least one committer and no changes requested.

yiguolei pushed a commit that referenced this pull request May 18, 2024
Co-authored-by: cjj2010 <2449402815@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants