DRILL-6321: Lateral Join and Unnest - star column prefix #1275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
chunhui-shi
commented
May 18, 2018
chunhui-shi
commented
- Add prefix to unnest's star column
- add tests for output column verification
* Add prefix to unnest's star column * add tests for output column verification
| testBuilder() | ||
| .unOrdered() | ||
| .sqlQuery(Sql) | ||
| .baselineColumns("c_name", "c_id", "c_phone", "orders", "c_address", "o_id", "o_shop", "o_amount", "items") |
There was a problem hiding this comment.
I think this set of columns is not right. The UNNEST should produce only the top level column since that's what the planner knows about. De-constructing the underlying map in the data means that we will not be able to specify a column alias for the unnest output: e.g UNNEST(t.orders) as t2(o).
There was a problem hiding this comment.
The set of columns returned from UNNEST is another issue. And can be changed later if really needed. This fix is mainly about star case.
|
DRILL-6321 is marked as resolved with 1.14 Drill version. But it involves several PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.