DRILL-6956: Maintain a single entry for Drill Version in the pom file #1605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kkhatua This is a good change, but there are two concerns with it:
|
kkhatua
force-pushed
the
DRILL-6956
branch
2 times, most recently
from
99eca7c
to
603c53f
Compare
kkhatua
force-pushed
the
DRILL-6956
branch
3 times, most recently
from
786b9ad
to
4f31d68
Compare
kkhatua
force-pushed
the
DRILL-6956
branch
2 times, most recently
from
ab28ffd
to
806f169
Compare
vdiravka
requested changes
Apr 24, 2019
There was a problem hiding this comment.
@kkhatua
Looks like it is not full setup. flatten-maven-plugin should be added to replace ${revision} placeholders after generating artifacts.
Please check Install / Deploy section of https://maven.apache.org/maven-ci-friendly.html
Currently, updating the version information for a Drill release involves updating 30+ pom files. The right way would be to use the Multi Module Setup for Maven CI. https://maven.apache.org/maven-ci-friendly.html#Multi_Module_Setup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, updating the version information for a Drill release involves updating 30+ pom files.
The right way would be to use the Multi Module Setup for Maven CI.
https://maven.apache.org/maven-ci-friendly.html#Multi_Module_Setup