Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds taskType dimension to task count metrics #16403

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mchoudhary-cflt
Copy link

@mchoudhary-cflt mchoudhary-cflt commented May 6, 2024

Adds taskType dimension to task count metrics to enable visibility into the distribution of task states by their type

Description

Fixed the bug ...

Renamed the class ...

Added a forbidden-apis entry ...

Release note

For tips about how to write a good release note, see Release notes.


Key changed/added classes in this PR
  • MyFoo
  • OurBar
  • TheirBaz

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@kfaraz
Copy link
Contributor

kfaraz commented May 9, 2024

Thanks for the PR, @mchoudhary-cflt . But these methods of TaskCountStatsProvider have been deprecated for a few releases.

I have created PR #16423 to remove the deprecated methods, simplify the reporting of these metrics and add the dimension taskType.

You can retain the doc changes and the statsd/prometheus emitter config changes in this PR and they can be merged once #16423 is merged. Please let me know if that works for you.

@mchoudhary-cflt
Copy link
Author

Sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants