Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: datasetId for series, not datasetIndex. close #284 #302

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: datasetId for series, not datasetIndex. close #284 #302

wants to merge 1 commit into from

Conversation

YuShengHou
Copy link

fix about issues #284

@YuShengHou YuShengHou changed the title fix: datasetId for series, not datasetIndex fix: #284 datasetId for series, not datasetIndex Oct 5, 2022
@YuShengHou YuShengHou changed the title fix: #284 datasetId for series, not datasetIndex fix: datasetId for series, not datasetIndex. close #284 Oct 5, 2022
Ovilia
Ovilia requested changes Nov 23, 2022
View reviewed changes
Copy link
Contributor

@Ovilia Ovilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

datasetIndex should not be removed. Instead, datasetId should be added like series.id.

@Lovor01
Copy link

Lovor01 commented Mar 28, 2024

datasetId is integrated (it works for me), but is missing from documentation

@YuShengHou
Copy link
Author

YuShengHou commented Mar 28, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ovilia Ovilia Ovilia requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@YuShengHou @Lovor01 @Ovilia