Fix stacked areas overflow on null values when connectNulls is true

apache · Feb 15, 2024 · 194a793 · 194a793
1 parent 031a908
commit 194a793
Showing 1 changed file with 25 additions and 16 deletions.
diff --git a/src/chart/line/helper.ts b/src/chart/line/helper.ts
@@ -112,23 +112,32 @@ function getValueStart(valueAxis: Axis, valueOrigin: LineSeriesOption['areaStyle
 }
 
 export function getStackedOnPoint(
-    dataCoordInfo: CoordInfo,
-    coordSys: Cartesian2D | Polar,
-    data: SeriesData,
-    idx: number
+  dataCoordInfo: CoordInfo,
+  coordSys: Cartesian2D | Polar,
+  data: SeriesData,
+  idx: number
 ) {
-    let value = NaN;
-    if (dataCoordInfo.stacked) {
-        value = data.get(data.getCalculationInfo('stackedOverDimension'), idx) as number;
-    }
-    if (isNaN(value)) {
-        value = dataCoordInfo.valueStart;
-    }
+  let stackedOverValue = NaN;
+  let stackResultValue = NaN;
+  if (dataCoordInfo.stacked) {
+    stackedOverValue = data.get(
+      data.getCalculationInfo('stackedOverDimension'),
+      idx
+    ) as number;
+    stackResultValue = data.get(
+      data.getCalculationInfo('stackResultDimension'),
+      idx
+    ) as number;
+  }
+
+  if (isNaN(stackedOverValue) && !isNaN(stackResultValue)) {
+    stackedOverValue = dataCoordInfo.valueStart;
+  }
 
-    const baseDataOffset = dataCoordInfo.baseDataOffset;
-    const stackedData = [];
-    stackedData[baseDataOffset] = data.get(dataCoordInfo.baseDim, idx);
-    stackedData[1 - baseDataOffset] = value;
+  const baseDataOffset = dataCoordInfo.baseDataOffset;
+  const stackedData = [];
+  stackedData[baseDataOffset] = data.get(dataCoordInfo.baseDim, idx);
+  stackedData[1 - baseDataOffset] = stackedOverValue;
 
-    return coordSys.dataToPoint(stackedData);
+  return coordSys.dataToPoint(stackedData);
 }