Merge pull request #19847 from zettca/fix/bigint

fix: detectValue & parseDataValue not crashing with BigInt
apache · Apr 29, 2024 · bdc5d4f · bdc5d4f
2 parents 697e798 + e23a407
commit bdc5d4f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/data/helper/dataValueHelper.ts b/src/data/helper/dataValueHelper.ts
@@ -67,7 +67,7 @@ export function parseDataValue(
         ? NaN
         // If string (like '-'), using '+' parse to NaN
         // If object, also parse to NaN
-        : +value;
+        : Number(value);
 };
 
 

diff --git a/src/data/helper/sourceHelper.ts b/src/data/helper/sourceHelper.ts
@@ -449,8 +449,8 @@ function doGuessOrdinal(
     function detectValue(val: OptionDataValue): BeOrdinalValue {
         const beStr = isString(val);
         // Consider usage convenience, '1', '2' will be treated as "number".
-        // `isFinit('')` get `true`.
-        if (val != null && isFinite(val as number) && val !== '') {
+        // `Number('')` (or any whitespace) is `0`.
+        if (val != null && Number.isFinite(Number(val)) && val !== '') {
             return beStr ? BE_ORDINAL.Might : BE_ORDINAL.Not;
         }
         else if (beStr && val !== '-') {