Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lines): Lines series symbolSize cannot be updated. close #18350 #18379

Merged
merged 4 commits into from
Mar 31, 2023

Conversation

cvSoldier
Copy link
Contributor

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Solve the bug that attributes such as symbolSize will not be updated by using all attributes of symbol as value

Fixed issues

Details

Before: What was the problem?

The width and color of lines are changed based on the new option, but symbolSize isn't changed

After: How does it behave after the fixing?

The styles of lines must be corresponding with the new option

Document Info

One of the following should be checked.

  • This PR doesn't relate to document changes
  • The document should be updated later
  • The document changes have been made in apache/echarts-doc#xxx

Misc

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

N.A.

Others

Link to Minimal Reproduction

Merging options

  • Please squash the commits into a single one when merging.

Other information

@echarts-bot
Copy link

echarts-bot bot commented Mar 14, 2023

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

Copy link
Contributor

@Ovilia Ovilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for your contribution. Please add a test case.

@cvSoldier
Copy link
Contributor Author

cvSoldier commented Mar 21, 2023

@Ovilia Test case was added, please review again.
Besides I am a bit confused, in Run test cases it is written that just need Run the related tests of the modified view, but after running all the test cases, I found that some of them reported errors:
image
After debug , they did not involve the code I modified, so it is a bit strange whether this is my problem?
And another question, is there no document showing how to add action in the test case, because I didn't find the relevant content, it took me a lot of time.

@cvSoldier cvSoldier requested a review from Ovilia March 22, 2023 08:34
@Ovilia
Copy link
Contributor

Ovilia commented Mar 23, 2023

Hi, at the top menu, please check the first checkbox and select the latest nightly build of 5.4.x so that your local code is compared to current master code. If the checkbox is not selected, it's compared to the last release, so that there are many code not related to your pull request.

@Ovilia
Copy link
Contributor

Ovilia commented Mar 23, 2023

Please fix the lint problem in the CI.

@cvSoldier
Copy link
Contributor Author

found that ci failed again,:worried: but I didn't understand the reason. Do I need to commit any changes?

@cvSoldier
Copy link
Contributor Author

Hi @Ovilia. Since all checks have passed, may I ask if it's ready for merging now?
(kind of exciting for becoming a contributor)

Copy link
Contributor

@Ovilia Ovilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@Ovilia Ovilia merged commit 8abf36c into apache:master Mar 31, 2023
2 checks passed
@echarts-bot
Copy link

echarts-bot bot commented Mar 31, 2023

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

1 similar comment
@echarts-bot
Copy link

echarts-bot bot commented Mar 31, 2023

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants