-
Notifications
You must be signed in to change notification settings - Fork 19.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(lines): Lines series symbolSize cannot be updated. close #18350 #18379
Conversation
Thanks for your contribution! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks for your contribution. Please add a test case.
@Ovilia Test case was added, please review again. |
Hi, at the top menu, please check the first checkbox and select the latest nightly build of 5.4.x so that your local code is compared to current master code. If the checkbox is not selected, it's compared to the last release, so that there are many code not related to your pull request. |
Please fix the lint problem in the CI. |
found that ci failed again,:worried: but I didn't understand the reason. Do I need to commit any changes? |
Hi @Ovilia. Since all checks have passed, may I ask if it's ready for merging now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution!
Congratulations! Your PR has been merged. Thanks for your contribution! 👍 |
1 similar comment
Congratulations! Your PR has been merged. Thanks for your contribution! 👍 |
Brief Information
This pull request is in the type of:
What does this PR do?
Solve the bug that attributes such as symbolSize will not be updated by using all attributes of symbol as value
Fixed issues
Details
Before: What was the problem?
The width and color of lines are changed based on the new option, but symbolSize isn't changed
After: How does it behave after the fixing?
The styles of lines must be corresponding with the new option
Document Info
One of the following should be checked.
Misc
ZRender Changes
Related test cases or examples to use the new APIs
N.A.
Others
Link to Minimal Reproduction
Merging options
Other information