fix(legend): fix dataItem undefined error #18390
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi. Thanks for your contribution. If this PR doesn't have a related issue to describe the problem, please provide an online link with Official Editor, CodePen, CodeSandbox or JSFiddle for the reviewer to understand the problem. Thanks! |
|
This pr is to fixed the null error by this commit: 4fe4561 In the same option, v5.4.0 can display it while v5.4.1 cannot. Echarts v5.4.0: https://codepen.io/roojay/pen/jOvvmQV Echarts v5.4.1 is error: https://codepen.io/roojay/pen/MWqqmZo |
Ovilia
requested changes
Mar 21, 2023
Ovilia
requested changes
Mar 23, 2023
Ovilia
requested changes
Mar 24, 2023
There was a problem hiding this comment.
The source code change looks good to me. Please add a case in https://github.com/apache/echarts/blob/master/test/legend.html
roojay520
force-pushed
the
master
branch
2 times, most recently
from
dfe8f5a
to
b935760
Compare
|
@Ovilia test case added. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of:
What does this PR do?
Fix LegendModel error when dataItem is undefined
Fixed issues
Details
Before: What was the problem?
The possibility of
dataItembeing empty was not taken into consideration here, and itsnameis directly retrieved:After: How does it behave after the fixing?
Exclude empty
dataItemand empty legend names.Document Info
One of the following should be checked.
Misc
ZRender Changes
Related test cases or examples to use the new APIs
N.A.
Others
Merging options
Other information