Fix #19247 - [Bug fixing] Echart splitline not showing on interval function (issue 19247) #19382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- removed redundant first tick - included shift to coord
|
Thanks for your contribution! |
|
The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-19382@583f416 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of:
What does this PR do?
This PR fixes the issue mentioned in issue 19247, where the splitline does not display at the right interval when there is only one tick given by the user.
Fixed issues
#19247
Details
Before: What was the problem?
When the given data array (which represents the intervals) has only one tick, the split line only appears at the left side of the graph. Datazoom-in also shows incorrect splitline.
Before Zooming in
After Zooming in
After: How does it behave after the fixing?
After the fix, the left splitline appears next to the correct interval given by the given data array. Datazoom-in also shows right interval splitline.
Before Zooming in
After zooming in
Document Info
One of the following should be checked.
Misc
ZRender Changes
Related test cases or examples to use the new APIs
N.A.
Others
Merging options
Other information
Axis.ts has been modified to fix the bug and a new html test file called splitline_2.html has been added under the test folder.