Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pie): 'itemRadiusScale' function added for pie series #19435
base: master
Are you sure you want to change the base?
feat(pie): 'itemRadiusScale' function added for pie series #19435
Changes from 2 commits
c711f3a
0e29090
a9eed59
1f544cc
921cb9a
a0db5b4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest considering another name than
radius
because it may cause confusion with emphasis.scaleSize, which is the enlarging animation when emphasizing. You are welcomed to suggest a new name.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
scalePercent
itemStyle.radius
itemStyle.scalePercent
(preferred)also it would be an
itemStyle.scaleSize
. but I think (not 100% sure yet =), i will lose the ability to use nonlinear functions. because percentages are calculated on the lib side in this caseThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would personnally perfer
itemStyle.radiusPercent
to avoid usingscaleXXX
, but not with very strong preference. If onlyitemStyle.xxx
is used but noseries.xxx
, I think we should skip the callback function.In ECharts, for options support both value and percentage form (like radius, we usually use strings like
'30%'
to represent percentage. But since we don't support number type in our case, I think a 0-1 number type is acceptable.Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.