Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(WIP): axis with break #19459

Draft
wants to merge 25 commits into
base: next
Choose a base branch
from
Draft

feat(WIP): axis with break #19459

wants to merge 25 commits into from

Conversation

Ovilia
Copy link
Contributor

@Ovilia Ovilia commented Jan 2, 2024

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

image

Provide a way to make break axes that may range too wide.

Fixed issues

Details

Before: What was the problem?

After: How does it behave after the fixing?

Document Info

One of the following should be checked.

  • This PR doesn't relate to document changes
  • The document should be updated later
  • The document changes have been made in apache/echarts-doc#xxx

Misc

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

N.A.

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

Copy link

echarts-bot bot commented Jan 2, 2024

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

⚠️ MISSING DOCUMENT INFO: Please make sure one of the document options are checked in this PR's description. Search "Document Info" in the description of this PR. This should be done either by the author or the reviewers of the PR.

@Ovilia
Copy link
Contributor Author

Ovilia commented Jan 2, 2024

Discussion: Should this feature be called "axis breaking" or "axis collapsing"? This may probably depend on if I can implement break folding/unfolding feature.

I think the HighCharts implementation is quite tricky for the users. Although we can provide similar APIs with graphic.elements to enable developers do similar things, I'd prefer implementing such design as default axis broken style so that it won't be misleading to viewers if developers aren't very experienced in dataviz and don't know how to (or why should) let viewers understand this is an axis skipped some ranges.

Copy link
Contributor

github-actions bot commented Jan 2, 2024

The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-19459@f5f246d

@pull-request-size pull-request-size bot added size/XL and removed size/L labels Jan 4, 2024
@Ovilia Ovilia added this to the 6.0.0 milestone Jan 31, 2024
@Ovilia Ovilia changed the base branch from master to next May 16, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In progress
Development

Successfully merging this pull request may close these issues.

None yet

2 participants