Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(time): add meridian template {a}/{A} #19888

Merged

Conversation

maurodesouza
Copy link
Contributor

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

I added a meridian template to the time format.

Fixed issues

Details

Before: What was the problem?

There wasn't a template to show the meridian.

After: How does it behave after the fixing?

Now it's possible to use the template {a} | {A} to show the meridian on the time formatting

Document Info

One of the following should be checked.

  • This PR doesn't relate to document changes
  • The document should be updated later
  • The document changes have been made in apache/echarts-doc#xxx

Misc

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

N.A.

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

Copy link

echarts-bot bot commented May 1, 2024

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

Document changes are required in this PR. Please also make a PR to apache/echarts-doc for document changes and update the issue id in the PR description. When the doc PR is merged, the maintainers will remove the PR: awaiting doc label.

@plainheart plainheart changed the title feat(time): add meridian template feat(time): add meridian template {a}/{A} May 6, 2024
@plainheart plainheart added this to the 5.5.1 milestone May 6, 2024
Copy link
Contributor

github-actions bot commented May 6, 2024

The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-19888@96f4a5f

@plainheart plainheart merged commit 3cdc703 into apache:master May 6, 2024
2 checks passed
Copy link

echarts-bot bot commented May 6, 2024

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@bhavishyachandra
Copy link

Thanks for the contribution @maurodesouza! I've waited a long time for this one.
@plainheart any idea when you plan on releasing 5.5.1?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: awaiting doc Document changes is required for this PR. PR: first-time contributor size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants